improvement: clear diagnostics in downstream targets #6604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
changed the title
kasiaMarek
changed the title
tgodzik
requested changes
Jul 23, 2024
| @@ -101,7 +105,7 @@ final class Compilations( | |||
| result <- targetOpt match { | |||
| case None => Future.successful(empty) | |||
| case Some(target) => | |||
| compileBatch(target) | |||
| compileBatch(target) // HERE | |||
There was a problem hiding this comment.
Suggested change
| compileBatch(target) // HERE | |
| compileBatch(target) |
|
|
||
| import ch.epfl.scala.bsp4j.BuildTargetIdentifier | ||
|
|
||
| class BuildTargetMapper { |
There was a problem hiding this comment.
Suggested change
| class BuildTargetMapper { | |
| class PreviouslyCompiledTargets { |
?
There was a problem hiding this comment.
Not perfect, but I don't have a better name. I also added a comment, because the whole logic may not be that obvious. Can you check if it is understandable?
| val targets = for { | ||
| path <- diagnostics.keySet | ||
| targets <- buildTargets.sourceBuildTargets(path) | ||
| if targets.forall(inverseDeps.apply) |
There was a problem hiding this comment.
Suggested change
| if targets.forall(inverseDeps.apply) | |
| if targets.exists(inverseDeps.apply) |
?
tgodzik
approved these changes
Jul 24, 2024
metals/src/main/scala/scala/meta/internal/metals/Compilations.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/Diagnostics.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/Compilations.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when compilation in a upstream target failed. We don't do it for Scala 3 best effort compilation, for which even if compilation fails upstream often downstream projects will also get recompiled.
resolves: #2670