Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add release notes for Metals 1.3.3 #6578

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jul 10, 2024

No description provided.

@tgodzik tgodzik requested a review from kasiaMarek July 10, 2024 17:53
website/blog/2024-07-10-thallium.md Outdated Show resolved Hide resolved
website/blog/2024-07-10-thallium.md Outdated Show resolved Hide resolved
website/blog/2024-07-10-thallium.md Outdated Show resolved Hide resolved
website/blog/2024-07-10-thallium.md Outdated Show resolved Hide resolved
website/blog/2024-07-10-thallium.md Outdated Show resolved Hide resolved
@tgodzik tgodzik force-pushed the release-notes-1.3.3 branch 2 times, most recently from 114d360 to d89a891 Compare July 11, 2024 14:32
@tgodzik tgodzik requested a review from kasiaMarek July 11, 2024 15:36
Comment on lines 71 to 72
we need to specify that certain value can be of more than one type. If used
together with intersection types it will still work as expected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this sentence If used together with intersection types it will still work as expected. to line 83. Otherwise it makes it sound like union types work with intersection, where we want to say that the feature also works with intersection.

@tgodzik tgodzik force-pushed the release-notes-1.3.3 branch from d89a891 to a7fd3b0 Compare July 12, 2024 12:44
@tgodzik tgodzik marked this pull request as ready for review July 12, 2024 13:52
@tgodzik tgodzik merged commit 1a8e04d into scalameta:main Jul 12, 2024
22 of 24 checks passed
@tgodzik tgodzik deleted the release-notes-1.3.3 branch July 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants