bugfix: emit as extension method if member of implicit class with val in constructor #6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciesluk
reviewed
Mar 5, 2024
| indent, | ||
| isAfterNewline = false, | ||
| currRegion, | ||
| if (isInParen) expectTemplate else newExpectIgnoreBody |
There was a problem hiding this comment.
implicit class A(val v: Int) {
}
So when we are on class we'll add something like expect implicit class body, and then in parenthesis we'll emit val v but we want to keep the information about the "expect implicit class body", since it will be needed to construct correct region on {.
I wanted to write that this is safe, since there are no { } inside the constructor definition, but I'm second guessing this because of RefinedTypes.
There was a problem hiding this comment.
Fixed for refined types.
jkciesluk
approved these changes
Mar 6, 2024
Comment on lines
711
to
712
| // additionalSymbolCheck(doc.symbols) | ||
| // val symbols = doc.symbols.map(_.symbol).toList |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected to: #6156 (comment)