Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: handle nested java jars #6066

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Jan 31, 2024

resolves: #3815

This will slow down indexing, since now we read in java files, which we weren't doing before. However, go to implementation for dependency sources, will require of us to read in those files anyway.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! That one was way too long in the backlog. Great work 🎉

@@ -27,6 +27,14 @@ class JavaToplevelMtags(val input: Input.VirtualFile) extends MtagsIndexer {
}
}

def readPackage: List[String] = {
fetchToken
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fetchToken
fetchToken // start of file

maybe useful to comment?

@kasiaMarek kasiaMarek merged commit d1118ef into scalameta:main Feb 5, 2024
26 checks passed
@kasiaMarek kasiaMarek deleted the i3815 branch February 21, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files in sources jars with extra parent directories are not found
2 participants