bugfix: Extension method completion with name conflict

[jkciesluk]

When symbol with the same name as extension method was present in scope, completion edit would insert full symbol name of this method, which was incorrect.

package example

|import example.enrichments.*

object enrichments:
  extension (num: Int)
    def plus(other: Int): Int = num + other

def main = {
  val plus = 100.plus(19)
  val y = 19.pl@@ // resulted in
  val y = 19.example.enrichments.plus($0)
}

[kasiaMarek]

I don't think that it never makes sense for methods to put the full name:

//> using scala 3.3.1

object O {
  def mmm = 3
  class Test {
    val mmm = "aaaa"
    val foo = mmm@@
  }
}

[tgodzik]

Yeah, it seems that the issue is that we don't see the extension method in the scope and we don't shorten the name. Especially this doesn't make sense for extension methods.

[kasiaMarek]

Sure, it's just that this part of the code isn't used exclusively for extension methods.

[jkciesluk]

I don't think that it never makes sense for methods to put the full name

Thanks, I missed this case would also be changed, I changed it so the change applies only to extension methods.

[jkciesluk]

object O {
 def mmm = 3
 class Test {
   val mmm = "aaaa"
   val foo = mmm@@
 }
}

Actually there is a bug in this case in Scala 2 (compiler thinks that def mmm is in scope), I will work on it in a follow-up

[tgodzik]

LGTM!

[tgodzik]

Let's add the change to the compiler also.