Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Document highlight on anon-fun parameters in Scala 2 #5876

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

jkciesluk
Copy link
Member

@jkciesluk jkciesluk commented Nov 24, 2023

Previously anonymous function params with the same name were not distinguished

named.symbol.owner.isAnonymousFunction && owners.exists(owner =>
pos.isDefined && owner.pos.isDefined && owner.pos.point == named.symbol.owner.pos.point
)
def isForComprehensionOwner(named: NameTree) = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be awesome if you could group and name some things here to make it a bit more readable.

Previosuly anonymous function params with the same name were not distinguished
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit ea38fec into scalameta:main Nov 24, 2023
23 of 25 checks passed
@jkciesluk jkciesluk deleted the i5863 branch November 27, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants