Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Color vals of module type as classes #5862

Merged
merged 1 commit into from
Nov 24, 2023
Merged

improvement: Color vals of module type as classes #5862

merged 1 commit into from
Nov 24, 2023

Conversation

jkciesluk
Copy link
Member

eg. in val Foo = List, syntax highlighting on Foo will be the same as on List.
This was already true for vals defined in predef.scala

@jkciesluk
improvement: Color vals of module type as classes
57da233 
eg. in `val Foo = List`, syntax highlighting on Foo will be the same as on List
This was already true for vals defined in predef.scala
@jkciesluk jkciesluk requested a review from tgodzik November 21, 2023 09:02
tgodzik
tgodzik approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkciesluk jkciesluk merged commit 3a27d23 into scalameta:main Nov 24, 2023
23 of 25 checks passed
@jkciesluk jkciesluk deleted the sem-token-object branch November 24, 2023 08:22
@jkciesluk jkciesluk mentioned this pull request Nov 28, 2023
Merged
tgodzik added a commit to scala/scala3 that referenced this pull request Nov 28, 2023
@tgodzik
presentation compiler: Bugfix for semantic tokens and synthetic decor…
fab3f21 
…ations (#18955)

connected to scalameta/metals#5861 and
scalameta/metals#5862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkciesluk @tgodzik