bugfix: Remove PrettyType which might often fail in the compiler #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompiler Previously, we would use PrettyType to get any string output we wanted, however that broke if the type w read by the compiler. Now, we use standard compiler types to achive the same.
tgodzik
commented
Oct 18, 2023
| @@ -324,8 +318,11 @@ class MetalsGlobal( | |||
| history.config.get(ownerSymbol) match { | |||
| case Some(rename) if canRename(rename, ownerSymbol) => | |||
| TypeRef( | |||
| new PrettyType(rename.toString), | |||
| backtickifiedSymbol, | |||
| SingleType( | |||
There was a problem hiding this comment.
Replacing PrettyType with SingleType wa enough except for CompletionWorkspaceSuite.type-import where the type would alwyas be dealiased when printing. So I changed the symbol to always be error in shortened type.
tgodzik
commented
Oct 18, 2023
| not an important class. | ||
| */ | ||
| if (sym.isAliasType && sym != definitions.AnyRefClass) | ||
| backtickify(sym.newErrorSymbol(sym.name).updateInfo(sym.info)) |
There was a problem hiding this comment.
This makes sure that sym is not dealiased ince the error type is not an alias, but we still have all the correct type info.
kasiaMarek
approved these changes
Oct 18, 2023
jkciesluk
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would use PrettyType to get any string output we wanted, however that broke if the type w read by the compiler. Now, we use standard compiler types to achive the same.
fixes #5756 and #5755