bugfix: Don't read file for InteractiveSemanticdbdb if it doesn't exist #5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipwiech
reviewed
Oct 13, 2023
| } | ||
| } else | ||
| existingDoc | ||
| buffers.get(source).orElse { |
There was a problem hiding this comment.
Sorry to bother you, but out of curiosity, what is the difference between the unsavedContents (which by the way is still used above in the shouldTryCalculateInteractiveSemanticdb, not sure if that's intended now) and buffers.get(source)? 🤔
There was a problem hiding this comment.
Och, actually unsavedContents is unused and it should be used 😱 We use it for to warm up scalafix at the start 🤔
I changed it as a first option with fallback to buffers then to filesystem.
Previously, we would assume that any file that we want to calculate InteractiveSemanticdb for exists on the filesystem, which is not true. For example renamed files if renamed from terminal will stick in the editor and cause exceptions to be throw. Now, we also try to read it from buffers and from filesystem as a fallback if it exists on the filesystem.
jkciesluk
approved these changes
Oct 16, 2023
metals/src/main/scala/scala/meta/internal/metals/InteractiveSemanticdbs.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would assume that any file that we want to calculate InteractiveSemanticdb for exists on the filesystem, which is not true. For example renamed files if renamed from terminal will stick in the editor and cause exceptions to be throw. Now, we also try to read it from buffers and from filesystem as a fallback if it exists on the filesystem.