improvement: trim hover body #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Oct 2, 2023
| @@ -2,6 +2,8 @@ package scala.meta.internal.pc | |||
|
|
|||
| object HoverMarkup { | |||
|
|
|||
| private val MaxHoverBodyLength = 50000 | |||
There was a problem hiding this comment.
Is that based on some VS Code standard? If so could you add a link to where you found it?
There was a problem hiding this comment.
I didn't find any information about this in docs. It's based solely on experience, that the limit is around 100000.
There was a problem hiding this comment.
Could you add a comment about that then? That it's based on the experiment as of day x.y.z
jkciesluk
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5679