bugfix: Semantic tokens for multiline strings in Scala3 worksheets #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multiline strings, we highlight the entire line, so we need to adjust the length by removing additional indent
jkciesluk
force-pushed
the
sem-worksheet-3-str
branch
from
8607fd9 to
e61f522
Compare
kasiaMarek
approved these changes
Oct 2, 2023
| @@ -472,26 +473,47 @@ class Compilers( | |||
| } | |||
|
|
|||
| @tailrec | |||
| @nowarn | |||
There was a problem hiding this comment.
Otherwise we get warning that match is not exhaustive, but we can ignore since the length of this list will always be a multiple of 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multiline strings, we highlight the entire line, so we need to adjust the length by removing additional indent