improvement: add do not show bsp errors option #5678
Conversation
| ) | ||
| } else { | ||
| ( | ||
| makeLongMessage(message), | ||
| List(goToLogs, restartBuildServer, dismiss), | ||
| List(goToLogs, restartBuildServer, dismiss, doNotShowErrors), |
There was a problem hiding this comment.
| List(goToLogs, restartBuildServer, dismiss, doNotShowErrors), | |
| List(goToLogs, dismiss, doNotShowErrors), |
I am wondering it even help, most people will probably not restart or click mindlessly on it without looking into logs. We could mention it in the message. "the error might require restating build server"
| @@ -62,6 +67,8 @@ class BspErrorHandler( | |||
| restartBspServer().ignoreValue | |||
| case BspErrorHandler.dismiss => | |||
| Future.successful(dismissedErrors.add(message)).ignoreValue | |||
| case BspErrorHandler.doNotShowErrors => | |||
| Future.successful { doNotShowErrors = true } | |||
There was a problem hiding this comment.
Let's save it to database as in case of other notifications
There was a problem hiding this comment.
Don't we want to move this long term to bsp status + doctor anyway? Then this flag won't be needed anyway.
There was a problem hiding this comment.
Hmm.... in that case yeah. Are we able to sensibly move it to status? We could add the option to disable for now until this is implemented
| @@ -0,0 +1,4 @@ | |||
| -- If should show bsp errors | |||
| create table show_bsp_errors( | |||
There was a problem hiding this comment.
We could add it to the notifications table, no?
There was a problem hiding this comment.
Somehow I wasn't aware we had such a generic mechanism for notifications.
There was a problem hiding this comment.
Sorry! Should have mentioned it earlier
kasiaMarek
force-pushed
the
donot-show-bsp-errors
branch
from
bca9601 to
fda848a
Compare
Add possibility to stop showing bsp errors.