Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Make sure we are using latest known scalameta version #5675

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 25, 2023

PReviously, we were using the latest published scalameta version, which was caused by me setting first latest semanticdb version (that is not an issue), but then I also added the same scalameta version in order to not have potential mismatches between the two. This caused a breaking change in scalameta internal code to break metals CI. Now, we set the maximum version to be V.scalameta

PReviously, we were using the latest published scalameta version, which was caused by me setting first latest semanticdb version (that is not an issue), but then I also added the same scalameta version in order to not have potential mismatches between the two. This caused a breaking change in scalameta internal code to break metals CI. Now, we set the maximum version to be V.scalameta
Copy link
Contributor

@kasiaMarek kasiaMarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's reasonable. However, my understanding is that the main point of this was to add a proper version to the metals-sbt plugin, where we don't really care if the version is "<= V.scalameta" and this additional constraint is not needed there. But I'm not sure how important it is for us to be as up to date as possible.

@tgodzik
Copy link
Contributor Author

tgodzik commented Sep 25, 2023

I guess that's reasonable. However, my understanding is that the main point of this was to add a proper version to the metals-sbt plugin, where we don't really care if the version is "<= V.scalameta" and this additional constraint is not needed there. But I'm not sure how important it is for us to be as up to date as possible.

That shouldn't be necessary and also the newer version could be broken. We wouldn't run any test to verify anything on the newer version.

@tgodzik tgodzik merged commit 785d3f7 into scalameta:main Sep 26, 2023
23 of 24 checks passed
@tgodzik tgodzik deleted the fix-ci-again branch September 26, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants