Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Update bsp4j from 2.1.0-M5 to 2.1.0-M6 #5664

Closed
wants to merge 5 commits into from

Conversation

scalameta-bot
Copy link
Contributor

About this PR

πŸ“¦ Updates ch.epfl.scala:bsp4j from 2.1.0-M5 to 2.1.0-M6

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (2.1.0-M5).
You might want to review and update them manually.

website/blog/2022-07-04-aluminium.md
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "bsp4j" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "ch.epfl.scala", artifactId = "bsp4j" }
}]
labels: library-update, early-semver-pre-release, semver-spec-pre-release, old-version-remains, commit-count:1

@tgodzik
Copy link
Contributor

tgodzik commented Sep 27, 2023

Looks like we need to postpone this, since JDK 8 was dropped :/

@tgodzik tgodzik closed this Oct 2, 2023
@lefou
Copy link
Contributor

lefou commented Oct 2, 2023

Looks like we need to postpone this, since JDK 8 was dropped :/

Are you sure? Is this noted somewhere or just a observation while you tested it? I upgraded to 2.1.0-M6 in Mill (com-lihaoyi/mill#2794) and our CI tests on Java 8 all succeeded. I have to admit we only have rudimentary support for BSP in the test suite.

@tgodzik
Copy link
Contributor

tgodzik commented Oct 2, 2023

Hmm... That's what I would assume:

[error] ==> X tests.classFinder.ClassNameResolverSuite.simple1  0.0s java.lang.BootstrapMethodError: java.lang.UnsupportedClassVersionError: ch/epfl/scala/bsp4j/BuildTargetIdentifier has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

and it's released under Java 11:

https://github.com/build-server-protocol/build-server-protocol/blob/master/.github/workflows/release.yml#L17

@lefou
Copy link
Contributor

lefou commented Oct 2, 2023

Ok, thanks. Looks like I need to revert my PR in Mill. Thanks for the follow up.

@lefou
Copy link
Contributor

lefou commented Oct 2, 2023

There is a new version 2.1.0-M7 which fixes this issue.

@tgodzik tgodzik deleted the update/bsp4j-2.1.0-M6 branch October 3, 2023 08:44
@scalameta-bot
Copy link
Contributor Author

Superseded by #5718.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants