Bump swoval to 2.1.12 #5662
Closed
Bump swoval to 2.1.12 #5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered a small regression that caused sbt's tests to fail in 2.1.11 (sbt/io#352). The 2.1.12 release fixes the regression (swoval/swoval#173) while still making the switch from the jni based directory lister to the nio based directory lister on windows. It is possible that 2.1.12 is slower than 2.1.11 on Windows because it restores some additional directory scanning during registration. My intuition is that it should not go back up to 14 minutes for the reporting user's use case but it might not be as quick as 10 seconds.
|
Thanks for the quick fix! The bots already updated the version and merged it during the night when I was not watching 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the churn but I discovered a small regression that caused sbt's tests to fail in 2.1.11 (sbt/io#352). The 2.1.12 release fixes the regression (sbt/io#353) while still making the switch from the jni based directory lister to the nio based directory lister on windows. It is possible that the fix swoval/swoval#173 might make 2.1.12 somewhat slower than 2.1.11 on Windows because it restores some additional directory scanning during registration. My intuition is that it should not go back up to 14 minutes for the reporting user's use case but it might not be as quick as 10 seconds.