bugfix: handle CR #5651
Closed
bugfix: handle CR #5651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should be able to close this as it's already handled on scalaemta side, no? |
|
Handled in: scalameta/scalameta#3343 |
|
@kasiaMarek: Would it make sense to maybe at least keep the tests from this PR, considering that the Scalameta one doesn't seem to have any? 🤔 |
Yeah, we should add it when we will bump the scalameta version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #5369
scala.meta.inputs.Input.VirtualFilecounts as new line only\n, where the library used byJavaMtagsand editors (at least VSCode) count all\r\n,\n, and\ras new lines.This is a workaround mapping the file content but maybe this should actually be adjusted in
scala.meta.inputs.Input.VirtualFile, @tgodzik ?