Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: deduplicate auto connect requests for scala-cli #5645

Merged
merged 1 commit into from
Sep 21, 2023
Merged

bugfix: deduplicate auto connect requests for scala-cli #5645

merged 1 commit into from
Sep 21, 2023

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Sep 14, 2023 •
edited
Loading

I'm hoping this will help with flaky scala-cli tests. Evidently, not really.

@kasiaMarek kasiaMarek force-pushed the scala-cli-deduplicate-conn branch from 7ace2ec to a3edc1e Compare September 14, 2023 12:27
@kasiaMarek kasiaMarek requested a review from tgodzik September 18, 2023 08:16
tgodzik
tgodzik approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think it should still improve things or at least eliminate one possible cause.

@tgodzik tgodzik merged commit b511ce9 into scalameta:main Sep 21, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasiaMarek @tgodzik