Improvement: adds details to github issue #4966
Conversation
kasiaMarek
force-pushed
the
github-issues-add-info
branch
from
27b638c to
6e5d120
Compare
metals/src/main/scala/scala/meta/internal/metals/GithubNewIssue.scala
Outdated
Show resolved
Hide resolved
kasiaMarek
force-pushed
the
github-issues-add-info
branch
from
6e5d120 to
c066cc7
Compare
| "Open the Metals repository on GitHub to ask a question or report a bug.", | ||
| ) | ||
|
|
||
| val OpenFeatureRequest = new OpenBrowserCommand( |
There was a problem hiding this comment.
You might need to add it to the list of commands at the bottom of the file here, since they need to be registered at the start for the client to pick them up
There was a problem hiding this comment.
Now, those are only visible in the tree view. But we do want to make it possible to add it to the command pallet. Is that what you mean?
There was a problem hiding this comment.
Ach, actually my bad. This is done via EchoCommand, but maybe it's good to let it work in Metals comamnds.
| currentBuildServer() | ||
| .map(s => s"${s.main.name} v${s.main.version}") | ||
| .orElse { | ||
| calculateNewBuildServer() match { |
There was a problem hiding this comment.
I wonder if this is not an actual data point here, since if you need to calcualte it then it's not connected. Maybe you could make the name soemthing like Disconnected: Bloop etc. ?
kasiaMarek
force-pushed
the
github-issues-add-info
branch
from
c066cc7 to
703bd46
Compare
|
You need to run |
kasiaMarek
force-pushed
the
github-issues-add-info
branch
from
703bd46 to
1f6654b
Compare
An improvement to "create GitHub issue" command.
Previously: it just redirected to the GitHub new issue creator.
Now: redirects and fills in basic information (metals version, os, editor/extension, java version).
connected to: #4924
Github issue example url:
https://github.com/scalameta/metals/issues/new?body=%3C%21--%0A++++++++Describe+the+bug+...%0A%0A++++++++Reproduction+steps%0A++++++++++1.+Go+to+...%0A++++++++++2.+Click+on+...%0A++++++++++3.+Scroll+down+to+...%0A++++++++++4.+See+error%0A--%3E%0A%0A%23%23%23+Expected+behaviour%3A%0A%0A%3C%21--+A+clear+and+concise+description+of+what+you+expected+to+happen.+--%3E%0A%0A**Operating+system%3A**%0AMac+OS+X%0A%0A**Java+version%3A**%0A17.0.1%0A%0A**Editor%2Fextension%3A**%0AVisual+Studio+Code+v1.75.1%0A%0A**Metals+version%3A**%0A0.11.11-SNAPSHOT%0A%0A%23%23%23+Extra+context+or+search+terms%3A%0A%3C%21--%0A++++++++-+Any+other+context+about+the+problem%0A++++++++-+Search+terms+to+help+others+discover+this%0A--%3E%0A%0A%23%23%23+Workspace+information%3A%0A%0A**Scala+versions%3A**+2.12.17%3B+2.13.10%3B+3.2.2%0A**Build+server%3A**+Bloop+v1.5.6%0A**All+build+tools+in+workspace%3A**+Bloop%3B+sbt%0A