bugfix: go to definition for extension method in companion object

scalameta · Sep 12, 2023 · 53e6b44 · 53e6b44
1 parent e6e4713
commit 53e6b44
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/mtags/src/main/scala-3/scala/meta/internal/pc/MetalsInteractive.scala b/mtags/src/main/scala-3/scala/meta/internal/pc/MetalsInteractive.scala
@@ -16,6 +16,7 @@ import dotty.tools.dotc.core.Types.Type
 import dotty.tools.dotc.interactive.SourceTree
 import dotty.tools.dotc.util.SourceFile
 import dotty.tools.dotc.util.SourcePosition
+import dotty.tools.dotc.core.Flags
 
 object MetalsInteractive:
 
@@ -266,6 +267,17 @@ object MetalsInteractive:
           case _ =>
             Nil
 
+      /* Workaround for missing span in:
+       * class MyIntOut(val value: Int)
+       * object MyIntOut:
+       *   extension (i: MyIntOut) def <<uneven>> = i.value % 2 == 1
+       *
+       * val a = MyIntOut(1).un@@even
+       */
+      case (a @ Apply(sel: Select, _)) :: _
+          if sel.span.isZeroExtent && sel.symbol.is(Flags.ExtensionMethod) =>
+        List((sel.symbol, a.typeOpt))
+
       case path @ head :: tail =>
         if head.symbol.is(Synthetic) then
           enclosingSymbolsWithExpressionType(

diff --git a/tests/cross/src/test/scala/tests/pc/PcDefinitionSuite.scala b/tests/cross/src/test/scala/tests/pc/PcDefinitionSuite.scala
@@ -559,4 +559,14 @@ class PcDefinitionSuite extends BasePcDefinitionSuite {
        |""".stripMargin,
   )
 
+  check(
+    "i5630".tag(IgnoreForScala3CompilerPC),
+    """|class MyIntOut(val value: Int)
+       |object MyIntOut:
+       |  extension (i: MyIntOut) def <<uneven>> = i.value % 2 == 1
+       |
+       |val a = MyIntOut(1).un@@even
+       |""".stripMargin,
+  )
+
 }