bugfix: Future filter error during connecting to build server

If we get to the state that selected build tool is no longer available, Metals would crash. This happend in `MetalsLspService.buildTool` if `BuildToolSelector.checkForChosenBuildTool` returned Future(None)
scalameta · Oct 19, 2023 · 2dc3125 · 2dc3125
1 parent 505e58c
commit 2dc3125
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/metals/src/main/scala/scala/meta/internal/builds/BuildToolSelector.scala b/metals/src/main/scala/scala/meta/internal/builds/BuildToolSelector.scala
@@ -23,9 +23,9 @@ final class BuildToolSelector(
       buildTools: List[BuildTool]
   ): Future[Option[BuildTool]] =
     tables.buildTool.selectedBuildTool match {
-      case Some(chosen) =>
+      case Some(chosen) if buildTools.exists(_.executableName == chosen) =>
         Future(buildTools.find(_.executableName == chosen))
-      case None =>
+      case _ =>
         buildTools match {
           case buildTool :: Nil =>
             tables.buildTool.chooseBuildTool(buildTool.executableName)

diff --git a/metals/src/main/scala/scala/meta/internal/metals/MetalsLspService.scala b/metals/src/main/scala/scala/meta/internal/metals/MetalsLspService.scala
@@ -1970,11 +1970,10 @@ class MetalsLspService(
       case Nil => Future(None)
       case buildTools =>
         for {
-          Some(buildTool) <- buildToolSelector.checkForChosenBuildTool(
+          buildTool <- buildToolSelector.checkForChosenBuildTool(
             buildTools
           )
-          if isCompatibleVersion(buildTool)
-        } yield Some(buildTool)
+        } yield buildTool.filter(isCompatibleVersion)
     }
   }