review fixes

scalameta · Sep 27, 2023 · 1adb6b2 · 1adb6b2
1 parent b25efa3
commit 1adb6b2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/metals/src/main/scala/scala/meta/internal/metals/MetalsLspService.scala b/metals/src/main/scala/scala/meta/internal/metals/MetalsLspService.scala
@@ -2053,9 +2053,8 @@ class MetalsLspService(
       !buildTools.isAutoConnectable()
       && buildTools.loadSupported.isEmpty
       && folder.isScalaProject()
-    ) {
-      scalaCli.setupIDE(folder)
-    } else Future.successful(())
+    ) scalaCli.setupIDE(folder)
+    else Future.successful(())
   }
 
   private def slowConnectToBloopServer(

diff --git a/metals/src/main/scala/scala/meta/internal/metals/WorkspaceFolders.scala b/metals/src/main/scala/scala/meta/internal/metals/WorkspaceFolders.scala
@@ -75,7 +75,7 @@ class WorkspaceFolders(
         if (!isIn(services, folder)) {
           WorkspaceFoldersServices(
             services :+ newService,
-            nonScalaProjects.filter(_ == folder),
+            nonScalaProjects.filterNot(_ == folder),
           )
         } else wfs
     }
@@ -101,14 +101,6 @@ class WorkspaceFolders(
 
 }
 
-trait MetalsLspServiceCreator {
-  def apply(
-      folder: Folder,
-      updateLoggerFiles: () => Future[Unit],
-      forceIsScalaProject: Boolean = false,
-  ): MetalsLspService
-}
-
 case class WorkspaceFoldersServices(
     services: List[MetalsLspService],
     nonScalaFolders: List[Folder],

diff --git a/metals/src/main/scala/scala/meta/metals/MetalsLanguageServer.scala b/metals/src/main/scala/scala/meta/metals/MetalsLanguageServer.scala
@@ -201,7 +201,7 @@ class MetalsLanguageServer(
           serverState.set(ServerState.Initialized(service))
           metalsService.underlying = service
 
-          folderPaths.foreach(folder =>
+          folderPathsWithScala.foreach(folder =>
             new StdReportContext(folder.toNIO).cleanUpOldReports()
           )