Make the entire API thread-safe. #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is not much point in trying to update it with the result of resolution.
This allows to have a single field, which can be `memoized` in the usual way. This will also become more important to make it thread-safe afterwards.
Somehow this was missed when introducing `memoized`.
Instead of storing them out-of-band in `PackageLoadingInfo`.
Instead of keeping them in a `PackageSymbol`-indexed map within the `Loader`. This gives the responsibility of handling the `PacakgeLoadingInfo` directly to the `PackageSymbol`, which therefore does not need to interact with the `Loader` itself anymore.
Rather than a global one for the whole context.
bishabosha
approved these changes
Jan 8, 2024
bishabosha
reviewed
Jan 9, 2024
|
|
||
| type DefiningTreeType = Nothing | ||
| type DeclType = Symbol | ||
|
|
||
| private[Symbols] val specialKind: SpecialKind = computeSpecialKind(name, owner) | ||
|
|
||
| /** Package loading info with raw data from the classpath. */ | ||
| private var optLoadingInfo: Option[PackageLoadingInfo] = None |
There was a problem hiding this comment.
just checking why this is safe to be a plain var?
There was a problem hiding this comment.
im assuming that the flow is that it is the thread that initialised the context is the thread that both creates this object and sets this, but then when is the update of setting this field "published" to other threads
There was a problem hiding this comment.
Hum, good question. For the members of other Symbols, they should be published thanks to myDeclarations.compareAndSet at their PackageSymbol's level. But for the things initialized during context initialization, we don't have a definitive release barrier. We might need to add one at the end of Context.initialize perhaps?
On the condition that the `ClasspathEntry`s used to create the `Context` are thread-safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the condition that the
ClasspathEntrys used to create theContextare thread-safe.