Fix #423: Merge the TypeBounds of type members without needing subtyping. #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an infinite recursion between looking up a type member of a refinement and subtyping of that member against the same refinement. This came from computing the merged TypeBounds of the type member during subtyping, which used subtyping to get rid of useless bounds.
We break the cycle by not using subtyping when merging the TypeBounds of a type member anymore. Instead, we manually dive into possibly-higher-kinded bounds (
TypeLambda
s themselves, but alsoNothing
andAnyKind
), and otherwise construction a union or intersection type.Unwrapping higher-kinded bounds is necessary because constructing a uniont or intersection requires proper types.
I did not manage to come up with an isolated reproduction, unfortunately. But with the dependency in #423, I can now successfully run the following test: