Work around https://github.com/lampepfl/dotty/issues/19237 #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not seem that the upstream issue will be fixed any time soon due to binary compatibility concerns. Nevertheless, it makes no sense, and it is not possible possible to create a *value* of a "package type". Therefore, we work around the issue by tolerating a `PackageRef` as the type of a PARAM of an inline accessor method. We replace it by `Nothing`, which matches the fact that no value can be created for it. Note that the *signature* and therefore the *signed name* of such a method will be different from what dotc computes, so it will still be semantically broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not seem that the upstream issue will be fixed any time soon due to binary compatibility concerns. Nevertheless, it makes no sense, and it is not possible possible to create a value of a "package type".
Therefore, we work around the issue by tolerating a
PackageRefas the type of a PARAM of an inline accessor method. We replace it byNothing, which matches the fact that no value can be created for it.Note that the signature and therefore the signed name of such a method will be different from what dotc computes, so it will still be semantically broken.