Preparations before reading Java annotations #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is only ever one `ConstantPool` per class file, so all these singleton type parameters are type-level busywork more than any real added safety.
We basically fuse the content of the old loop into `loadMembers()` and then into `createMember()`. There was no reason to buffer the list of read members in the middle. This has the added benefit that we can accurately compute `isSignaturePolymorphic` from the start, rather than guessing-and- checking.
Its body consisted of an only immediately-applied local def. We inline the def to get rid of the artificial nesting.
It did not contain any own state, so the singleton object is enough.
First, we read the structure of a classfile, independently of its class kind. Then, for a top-level class, we detect its class kind. At that point, we only look at the `Scala`, `ScalaSig` and `TASTY` attributes. We do not store any reference to other specific attributes. Third, the Loaders switch on the kind to use the appropriate loading functions. The loading function for Scala 2 rescans the attributes to find the signature annotation. The loading function for Java creates a map of all the available attributes, from which it uses--for now--the `InnerClasses` and `Signature` attributes. This frees the `Loaders` from manipulating specific sets of attributes that are needed by the loading functions. It will also be necessary for reading Java annotations, since they are stored in more attributes than were currently identified.
Merged
bishabosha
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.