Fix #336: Fix all the member-not-founds in the dotty codebase. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of "merely" `private[this]`. Apparently we stil find accesses of supposedly `private[this]` things in companion objects from their companion classes, through explicit `Select` nodes.
sjrd
force-pushed
the
member-not-found-fixes
branch
from
f29a740 to
db8fd96
Compare
Notably, in union types and array types. It almost always erases to `BoxedUnit`, except as the direct result type of a method.
For example, `s.c.i.Iterable <:< s.c.Iterable` when they are not applied.
It erases to `Product` and shows up as `Product` in call-site signatures.
We must only introduce `Any` if there is also no interface. If there is at least one interface but no class, we must keep it as is for the erasure to be consistent with what Java does.
sjrd
force-pushed
the
member-not-found-fixes
branch
from
db8fd96 to
d9ac25b
Compare
Outside of arrays or union types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After these changes, the
.symbolof everyTermReferenceTree(IdentorSelect) in thedottypackage (and subpackages) resolves without exception.