Automatically fill in positions of trees based on their children. #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pickling, dotc does not store the span of trees for which it is the same as the union of the spans of its children. In order to recover those, we now have an internal "auto" mode of `SourcePosition`, which stores the `SourceFile` but with `NoSpan`. When building a `Tree`, if it is given an "auto" position, we compute the span based on its children. We mimick the formula used by dotc to do so, but only upward (dotc also does some weird mutating downward propagation, but AFAICT it will always store the spans of leaf trees, so we don't need that).
|
Thanks I'll check that in the afternoon! |
adpi2
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pickling, dotc does not store the span of trees for which it is the same as the union of the spans of its children.
In order to recover those, we now have an internal "auto" mode of
SourcePosition, which stores theSourceFilebut withNoSpan. When building aTree, if it is given an "auto" position, we compute the span based on its children. We mimick the formula used by dotc to do so, but only upward (dotc also does some weird mutating downward propagation, but AFAICT it will always store the spans of leaf trees, so we don't need that).