Issue 1268 #1304
Closed
Issue 1268 #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I messed it up with commit messages... sorry! :) |
adpi2
reviewed
Nov 22, 2023
| Future.successful("No README found for this project, please check the repository") | ||
| } | ||
| } | ||
| .flatMap(res => Future { element.innerHTML = res }) |
There was a problem hiding this comment.
Suggested change
| .flatMap(res => Future { element.innerHTML = res }) | |
| .map(res => element.innerHTML = res) |
Comment on lines
+105
to
+109
| if (res.status == 200) { | ||
| res.text().toFuture | ||
| } else { | ||
| Future.successful("{\"default_branch\": \"master\"}") | ||
| } |
There was a problem hiding this comment.
`
For the fallback, I would avoid creating a JSON string if we then need to parse it and extract one field.
Suggested change
| if (res.status == 200) { | |
| res.text().toFuture | |
| } else { | |
| Future.successful("{\"default_branch\": \"master\"}") | |
| } | |
| def extractDefaultBranch(text: String): String = | |
| js.JSON.parse(text).asInstanceOf[Repo].default_branch | |
| if (res.status == 200) res.text().map(extractDefaultBranch).toFuture | |
| else Future.successful("master") |
Comment on lines
+64
to
+65
| def setLogo(): Future[Unit] = { | ||
| def getLogoAndSetHTML(branch: String, organization: String, repository: String): Unit = { |
There was a problem hiding this comment.
It does not just set the logo, it fixes all the URLs of all the images in the readme file.
Suggested change
| def setLogo(): Future[Unit] = { | |
| def getLogoAndSetHTML(branch: String, organization: String, repository: String): Unit = { | |
| def getDefaultBranchAndFixImages(): Future[Unit] = { | |
| def fixImages(branch: String, organization: String, repository: String): Unit = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1268