Show meta tag for Open Graph Protocol #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windymelt
force-pushed
the
introduce-ogp
branch
from
a87c4fc to
66f96f2
Compare
|
oops, we have to use |
|
Thanks @windymet for your very much welcome contribution. I don't have time to review it now but I'll do it next week. Do you have a screenshot of the final result? |
|
Hi, thanks for your response! http://localhost:8080/lampepfl/dotty 's DOM looks like: <head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
<title>dotty</title>
<!-- snip -->
<meta name="twitter:card" content="summary">
<meta name="twitter:site" content="@scala_lang">
<meta name="twitter:title" content="dotty">
<meta name="twitter:description" content="The Scala 3 compiler, also known as Dotty.">
<meta name="twitter:image" content="https://avatars.githubusercontent.com/u/2684793?v=4">
<meta property="og:title" content="Scaladex - lampepfl / dotty">
<meta property="og:url" content="https://index.scala-lang.org/lampepfl/dotty">
<meta property="og:type" content="article">
<meta property="og:description" content="The Scala 3 compiler, also known as Dotty.">
<meta property="og:site_name" content="Scaladex">
<meta property="og:image" content="https://avatars.githubusercontent.com/u/2684793?v=4">
</head>
Then embedded rendering becomes: from
to
I tested embedding using Ngrok. Though I embedded into Hatena Blog, one of famous blog service in Japan that recognize OGP, other blog service will render the page well. I think making attribute string from string interpolation is little bit unsafe; but Twirl will do its sanitize, and name of organization and repository should be safe string. |
adpi2
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Can I contribute some aesthetical enhancement on head tag?
I love Scaladex, but when I embed Scaladex project page, only very few data appears. I'd like to enrich rendering.
Currently we have twitter card meta tag for Scaladex. However, twitter card meta tag is intended to be used in Twitter(X).
Fortunately, there is another open protocol for embedding site: The Open Graph protocol. Though initially it is developed for Facebook, many blog / CMS supports OGP for embedding protocol.
I added some meta tag respecting
twitterCard. This Pull-Req enables rich rendering of embedded project.I hope this pull request will help good experience for Scaladex.