Splicing of default getters should not special case constructors with implicits #22344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Jan 10, 2025
| // Empty list is inserted for constructors where the first parameter list is implicit. | ||
| // | ||
| // Therefore, we need to ignore the first empty argument list. | ||
| // This is needed for the test tests/neg/i12344.scala |
There was a problem hiding this comment.
Just to keep track of some info, this test is now tests/neg-macros/i12344.scala and it seems that some of the discussions that led to this change are not relevant now (See #12344 (comment) and https://github.com/scala/scala3/pull/14840/files#diff-a602b2ba421d0da906b1d1915ca14c84b336da38e2ab907b695c441c5d58f5b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22061