Drop EmptyTuple handling from NamedTupleDecomposition.apply
#22340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously needed to handle the case where the result of `toTuple` was an `EmptyTuple` separately from the rest, since `apply` used to be only defined for `NonEmptyTuple`s. This was changed in scala#21291, making the inline match in `NamedTupleDecomposition.apply` no longer necessary. The underlying issue with the proxies introduced to handle opaque types with inline defs is likely still present. Nevertheless, it is probably best to fix this specific instance of the problem with NamedTuples as soon as possible. Fixes scala#22324
aherlihy
added a commit
to aherlihy/scala3
that referenced
this pull request
Jan 10, 2025
aherlihy
added a commit
to aherlihy/scala3
that referenced
this pull request
Jan 10, 2025
smarter
approved these changes
Jan 13, 2025
aherlihy
added a commit
to aherlihy/scala3
that referenced
this pull request
Jan 13, 2025
bracevac
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously needed to handle the case where the result of
toTuplewas anEmptyTupleseparately from the rest, sinceapplyused to be only defined forNonEmptyTuples. This was changed in #21291, making the inline match inNamedTupleDecomposition.applyno longer necessary.The underlying issue with the proxies introduced to handle opaque types with inline defs is likely still present. Nevertheless, it is probably best to fix this specific instance of the problem with NamedTuples as soon as possible.
Fixes #22324