REPL: Add back :silent command
#22248
Merged
+43
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has never been an option to the REPL user (until now), and warnings can always be turned off with `-nowarn` CLI argument or `:settings -nowarn`.
... so that we can toggle it
natsukagami
force-pushed
the
silent-repl
branch
from
af1d79c to
41f6869
Compare
Gedochao
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Error: Test dotty.tools.repl.TabcompleteTests.commands failed: java.lang.AssertionError: expected:<List(:doc, :exit, :help, :imports, :load, :quit, :reset, :settings, :type)> but was:<List(:doc, :exit, :help, :imports, :load, :quit, :reset, :settings, :silent, :type)>, took 1.132 sec
Error: at dotty.tools.repl.TabcompleteTests.commands$$anonfun$1(TabcompleteTests.scala:222)This test needs fixing, I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21661
quietflag to no longer silence warningsquietinto State of REPL:silentcommand to toggle automatic printing of outputs