Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLA checks after domain change of CLA check server #22148

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

WojciechMazur
Copy link
Contributor

https://www.lightbend.com/contribute/cla/scala/check/ now is a redirect to https://contribute.akka.io/contribute/cla/scala/check.
It's breaking CLA check becouse curl by default does not follow redirects

@hamzaremmal
Copy link
Member

Maybe the scala cla should be under scala-lang.org

@hamzaremmal hamzaremmal enabled auto-merge December 5, 2024 12:59
@hamzaremmal hamzaremmal merged commit c61897d into scala:main Dec 5, 2024
27 checks passed
@WojciechMazur WojciechMazur deleted the fix/cla-check branch December 5, 2024 14:33
WojciechMazur added a commit that referenced this pull request Dec 9, 2024
…3.6 (#22175)

Backports #22148 to the 3.6.3.

PR submitted by the release tooling.
@SethTisue
Copy link
Member

SethTisue commented Dec 10, 2024

Maybe the scala cla should be under scala-lang.org

nobody would actually be opposed, but also it's not clear if it's worth the bother

if we adopt @Friendseeker's https://github.com/Friendseeker/scala-cla (and presumably Jerry would allow the repo to be transferred to the scala org) then there would only be one place that needs to be updated when something changes, instead of having the details duplicated in many repos

@Friendseeker
Copy link
Contributor

Maybe the scala cla should be under scala-lang.org

nobody would actually be opposed, but also it's not clear if it's worth the bother

if we adopt @Friendseeker's https://github.com/Friendseeker/scala-cla (and presumably Jerry would allow the repo to be transferred to the scala org) then there would only be one place that needs to be updated when something changes, instead of having the details duplicated in many repos

What steps should I do to facilitate the transfer to the scala org?

@SethTisue
Copy link
Member

SethTisue commented Dec 10, 2024

We would have to temporarily grant you permission to create repos in https://github.com/scala ; then you'd do the transfer yourself; and then we'd probably want to revoke the permission, for security.

@Friendseeker
Copy link
Contributor

We would have to temporarily grant you permission to create repos in https://github.com/scala ; then you'd do the transfer yourself; and then we'd probably want to revoke the permission, for security.

Thanks for the explanation! I should be able to do the transfer anytime today. Just grant me the temp privilege & ping me.

@SethTisue
Copy link
Member

SethTisue commented Dec 10, 2024

@Friendseeker invite sent, to https://github.com/orgs/scala/teams/committers

I also temporarily checked this box:

Screenshot 2024-12-09 at 6 06 33 PM

at

https://github.com/organizations/scala/settings/member_privileges

which I'll need to to undo when you're done.

@Friendseeker
Copy link
Contributor

Friendseeker commented Dec 10, 2024

We would have to temporarily grant you permission to create repos in https://github.com/scala ; then you'd do the transfer yourself; and then we'd probably want to revoke the permission, for security.

@SethTisue Done! https://github.com/scala/scala-cla. Also added some unit tests to ensure the CLA check work as expected.

Btw if anything doesn't look right (e.g. license), feel free to push a commit that changes it directly. I am unfamiliar with the legal stuff but I want to reaffirm that I hereby transfer the ownership of scala-cla to scala org.

@hamzaremmal
Copy link
Member

@Friendseeker Is it okay if we rename the repository to scala/cla-verification-action ? Just in case one day scala-cli is transfered to scala, it will be easier to distinguish between the two of them.

@Friendseeker
Copy link
Contributor

Friendseeker commented Dec 10, 2024

@Friendseeker Is it okay if we rename the repository to scala/cla-verification-action ? Just in case one day scala-cli is transfered to scala, it will be easier to distinguish between the two of them.

That sounds fantastic! I also think that the name you are proposing is really self explanatory.

@SethTisue
Copy link
Member

how about scala/cla-checker? that's what we've long called it, the "CLA checker"

@Friendseeker
Copy link
Contributor

how about scala/cla-checker? that's what we've long called it, the "CLA checker"

Also sounds like a fantastic name! I am happy with either of the names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants