Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info implementation to pc #19812

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

kasiaMarek
Copy link
Contributor

@kasiaMarek kasiaMarek commented Feb 28, 2024

backport from metals: scalameta/metals#5623
backports also: scalameta/metals#6198

pkg: String,
parts: List[(String, Boolean)],
): List[Symbol] =
def collectSymbols(denotation: Denotation): List[Symbol] =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't .allSymbols handle this ?

catch case NonFatal(e) => Nil

val (searchedSymbol, alternativeSymbols) =
foundSymbols.partition(compilerSymbol =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can look better with fewer braces :D :

foundSymbols.partition: compilerSymbol =>
  SemanticdbSymbols.symbolName(compilerSymbol) == symbol

@kasiaMarek kasiaMarek merged commit e2c65e6 into scala:main Mar 8, 2024
19 checks passed
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
WojciechMazur pushed a commit that referenced this pull request Jul 2, 2024
WojciechMazur added a commit that referenced this pull request Jul 3, 2024
Backports #19812 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants