bugfix: Backticked named arguments #18704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
approved these changes
Oct 17, 2023
| @@ -200,6 +200,13 @@ abstract class PcCollector[T]( | |||
| val realName = arg.name.stripModuleClassSuffix.lastPart | |||
| if pos.span.start > arg.span.start && pos.span.end < arg.span.point + realName.length | |||
| then | |||
| val realName = arg.name.stripModuleClassSuffix.lastPart | |||
There was a problem hiding this comment.
This line is not necessary
Suggested change
| val realName = arg.name.stripModuleClassSuffix.lastPart |
rochala
approved these changes
Oct 17, 2023
rochala
approved these changes
Oct 17, 2023
jkciesluk
force-pushed
the
named-arg-backtick
branch
from
db418d3 to
bf46b49
Compare
rochala
added
the
area:presentation-compiler
WojciechMazur
added a commit
that referenced
this pull request
Jun 23, 2024
Backports #18704 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected to scalameta/metals#5725