Updated js-bridge with newest configuration #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bloop-config now has configuration for setting modulekindsplitstyele for esmodules
|
I had some trouble getting tests to run for this on my system and in CI with diffirent errors that didn't really make sense considering the changes in the PR, so it would be nice to see them run on CI here so I can actually know if I've broken anything or it's just some strange behavior I need to take a look at. |
|
Looks to be working. Would you mind contributing this to scalacenter/bloop ? I am already working around merging this fork to the main Bloop |
|
Yes, I'll PR this in scalacenter/bloop asap. |
|
No need for ASAP 😅 |
|
@tgodzik So, could not fork the original when I had a fork of a fork, so when I removed the fork apparently this PR is closed? Anyway... scalacenter#2359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.