Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: use exec in forwarder scripts (#1664) #1665

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

gaeljw
Copy link
Contributor

@gaeljw gaeljw commented Jan 6, 2025

Fix #1664

I tested on a personal case but please consider I'm not super experienced in Bash/SH, thus I may be missing a reason for which it wouldn't be the desired behaviour.

@gaeljw gaeljw changed the title 🐛 fix: use exec in forwarder scripts (#1664) Draft: 🐛 fix: use exec in forwarder scripts (#1664) Jan 6, 2025
@gaeljw gaeljw marked this pull request as draft January 6, 2025 16:29
@gaeljw gaeljw changed the title Draft: 🐛 fix: use exec in forwarder scripts (#1664) 🐛 fix: use exec in forwarder scripts (#1664) Jan 6, 2025
@gaeljw
Copy link
Contributor Author

gaeljw commented Jan 6, 2025

The check "Validate PR / scripted (ubuntu-latest, 8, zulu, +validateRpm)" is failing but I don't think it's related to my changes, is it? The error is not super clear to me.

@gaeljw gaeljw marked this pull request as ready for review January 6, 2025 17:05
@dwickern
Copy link
Collaborator

dwickern commented Jan 6, 2025

It's not related to your changes, there's an issue with sbt 2.x: sbt/sbt#7873

I re-ran the failing job

@muuki88 muuki88 added docker universal Zip, tar.gz, tgz and bash issues labels Jan 7, 2025
Copy link
Collaborator

@dwickern dwickern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should use exec here. Thanks!

@dwickern dwickern merged commit 29461e8 into sbt:main Jan 10, 2025
15 checks passed
@gaeljw gaeljw deleted the gh1664 branch January 10, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forwarder script do not use "exec"
3 participants