Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SBPP Checker] Callback and initial values #894

Open
wants to merge 3 commits into
base: php81
Choose a base branch
from

Conversation

DosMike
Copy link

@DosMike DosMike commented May 25, 2023

Description

As user of the SourceBans Checker API I would like to be notified when the bans and commbans counters are actually valid, or at least be provided with fallback values until they are.

Motivation and Context

As of 1.8.0 the values in g_iBanCounts[client] and g_iCommsCounts[client] remain stale between a disconnect and the async OnConnectBanCheck callback. This might cause issues if you want to rely on, or react to these values as soon as they are available. If a plugin is polling values this would currently still give incorrect results for quite some time, even if the the client is ingame AND authorized, thus resetting the values to -1.

How Has This Been Tested?

  • Smoke test in dev server + live env

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@DosMike DosMike marked this pull request as ready for review June 1, 2023 19:29
@Rushaway
Copy link
Contributor

Rushaway commented Jun 1, 2024

  • Can you change the version to 1.8.1 ?
  • Forward has to be created in the AskPluginLoad2

@DosMike
Copy link
Author

DosMike commented Jun 13, 2024

  • Can you change the version to 1.8.1 ?
  • Forward has to be created in the AskPluginLoad2

There you go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants