Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda packaging #516

Closed
wants to merge 3 commits into from
Closed

Conda packaging #516

wants to merge 3 commits into from

Conversation

stefanwezel
Copy link

  • Make sbi installable through conda
  • Based on existing PyPI

@stefanwezel stefanwezel added the enhancement New feature or request label Jun 30, 2021
@stefanwezel stefanwezel self-assigned this Jun 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #516 (18f20e6) into main (df147b1) will not change coverage.
The diff coverage is n/a.

❗ Current head 18f20e6 differs from pull request most recent head fc4f754. Consider uploading reports for the commit fc4f754 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #516   +/-   ##
=======================================
  Coverage   67.70%   67.70%           
=======================================
  Files          55       55           
  Lines        3970     3970           
=======================================
  Hits         2688     2688           
  Misses       1282     1282           
Flag Coverage Δ
unittests 67.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df147b1...fc4f754. Read the comment docs.

meta.yaml Outdated Show resolved Hide resolved
meta.yaml Outdated Show resolved Hide resolved
license_file:
summary: Simulation-based inference.
doc_url:
dev_url:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any documentation on this yaml quickly. I am a newbie to conda packaging.

But maybe this URL should point to our issues tab.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example from the conda docs suggests that it should point to the sbi GitHub repository itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then there should be 2 changes according to this example from the conda docs.

Suggested change
dev_url:
dev_url: https://github.com/mackelab/sbi

And we have to decide whether the home key should have the same value or not. Not that it matters much. ;-)

stefanwezel and others added 2 commits July 1, 2021 09:56
Co-authored-by: Peter Steinbach <[email protected]>
Co-authored-by: Peter Steinbach <[email protected]>
# - sbi.utils

about:
home: https://github.com/mackelab/sbi
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest

Suggested change
home: https://github.com/mackelab/sbi
home: https://www.mackelab.org/sbi/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, feel free to commit this.

@alvorithm
Copy link
Contributor

OK, so it turns out we would need to recursively package the dependency tree with conda (as per conda/conda-build#548), which takes too much work now, so closing the issue until somebody finds time.

Note the current pip-only dependencies seem to be: pyknos (no further deps), nflows, which depends on torchtestcase (potentially more deps in turn) and UMNN (https://github.com/AWehenkel/UMNN) (unclear deps).

@alvorithm alvorithm closed this Jul 12, 2021
@janfb janfb deleted the conda_packaging branch January 17, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants