-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda packaging #516
Conda packaging #516
Conversation
Codecov Report
@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 67.70% 67.70%
=======================================
Files 55 55
Lines 3970 3970
=======================================
Hits 2688 2688
Misses 1282 1282
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
license_file: | ||
summary: Simulation-based inference. | ||
doc_url: | ||
dev_url: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find any documentation on this yaml quickly. I am a newbie to conda packaging.
But maybe this URL should point to our issues tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example from the conda
docs suggests that it should point to the sbi
GitHub repository itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then there should be 2 changes according to this example from the conda docs.
dev_url: | |
dev_url: https://github.com/mackelab/sbi |
And we have to decide whether the home
key should have the same value or not. Not that it matters much. ;-)
Co-authored-by: Peter Steinbach <[email protected]>
Co-authored-by: Peter Steinbach <[email protected]>
# - sbi.utils | ||
|
||
about: | ||
home: https://github.com/mackelab/sbi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest
home: https://github.com/mackelab/sbi | |
home: https://www.mackelab.org/sbi/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, feel free to commit this.
OK, so it turns out we would need to recursively package the dependency tree with conda (as per conda/conda-build#548), which takes too much work now, so closing the issue until somebody finds time. Note the current pip-only dependencies seem to be: |
sbi
installable throughconda