Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-container, sbb-sticky-bar): add new color variants #3337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Jan 9, 2025

Preflight Checklist

Issue

This PR Closes #3171

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • add new color midnight and charcoal variants for the sbb-container and the sbb-sticky-bar
  • add a note about consumers setting negative if needed when a dark background is used

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@DavideMininni-Fincons DavideMininni-Fincons linked an issue Jan 9, 2025 that may be closed by this pull request
3 tasks
@DavideMininni-Fincons DavideMininni-Fincons changed the title feat(sbb-container, sbb-sticky-bar): add new color variants [WIP] feat(sbb-container, sbb-sticky-bar): add new color variants Jan 10, 2025
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jan 10, 2025
@DavideMininni-Fincons
Copy link
Contributor Author

Note for reviewers:
in the sticky-bar-stories.ts I was not sure about which combination could be relevant, so i created stories for charcoal sticky-bar on midnight container and viceversa, plus the expanded variant.
If not needed, they can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request]: Container with background colour Midnight
1 participant