fix: improve null/undefined type handling for Angular wrapper #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideMininni-Fincons
requested review from
kyubisation and
jeripeierSBB
as code owners
github-actions
bot
added
target: 2.x
pr: peer review required
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
github-actions
bot
added
pr: visual review required
diff-available
and removed
pr: visual review required
labels
github-actions
bot
added
the
pr: lead review approved
github-actions
bot
removed
the
pr: peer review required
sbb-design-systems-bot bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Changes are related to Angular wrapper's classes generation. - `sbb-calendar`: normalized null / undefined types for getters and setters; needs some fix for the `sbb-datepicker-toggle` - `sbb-navigation-action-common`: updated mixin type - `sbb-slider`: normalized type - `sbb-stepper`: some minor fix to normalize null values, which are already considered in the existing logic but not in typings - `sbb-tag-group`: normalized type - `sbb-time-input`: add null as type as in the getter - properties of `SbbStepValidateEventDetails` are now nullable and they are not optional anymore
kyubisation
pushed a commit
that referenced
this pull request
Dec 19, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.2](v2.0.1...v2.0.2) (2024-12-19) ### Bug Fixes * handle scroll events in custom scroll contexts ([#3310](#3310)) ([3634e37](3634e37)), closes [#3276](#3276) * improve null/undefined type handling for Angular wrapper ([#3302](#3302)) ([2f94992](2f94992)) * remove any type for Angular wrapper ([#3297](#3297)) ([dca7ba5](dca7ba5)) * remove leading inline padding from icon list ([#3311](#3311)) ([b9ce6d1](b9ce6d1)) * **sbb-accent-button:** adapt to new design ([#3313](#3313)) ([1af2691](1af2691)) * **sbb-message:** fix image alignment ([#3305](#3305)) ([1d4a5de](1d4a5de)) * **sbb-select:** update displayed value on option label change ([#3300](#3300)) ([3c2f3c5](3c2f3c5)) * **sbb-teaser-hero:** fix image size on custom width ([#3295](#3295)) ([5fc0634](5fc0634)) ### Documentation * override member properties in manifest ([#3307](#3307)) ([ba25320](ba25320)) * standardize usage of terms `CSS` and `Sass` ([#3290](#3290)) ([b52ac99](b52ac99)) ### Code Refactoring * move event handlers to constructors ([#3314](#3314)) ([18660a3](18660a3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are related to Angular wrapper's classes generation.
sbb-calendar: normalized null / undefined types for getters and setters; needs some fix for thesbb-datepicker-togglesbb-navigation-action-common: updated mixin typesbb-slider: normalized typesbb-stepper: some minor fix to normalize null values, which are already considered in the existing logic but not in typingssbb-tag-group: normalized typesbb-time-input: add null as type as in the getterSbbStepValidateEventDetailsare now nullable and they are not optional anymore