-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sbb-pearl-chain): implement new component structure #3172
Open
MarioCastigliano
wants to merge
21
commits into
main
Choose a base branch
from
refactor/pearl-chain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr: visual review required
diff-available
and removed
preview-available
diff-available
labels
Oct 28, 2024
MarioCastigliano
added
the
pr: peer review required
A peer review is required for this pull request
label
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review
src/elements/pearl-chain/pearl-chain-leg/pearl-chain-leg.visual.spec.ts
Outdated
Show resolved
Hide resolved
|
||
## States | ||
|
||
The `past`, `arrival-skipped`, `departure-skipped`, and `disruption` properties are connected to the self-named states. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some extra info about what happens when these params are set would be helpful (e.g. what is rendered when)
src/elements/pearl-chain/pearl-chain/pearl-chain.visual.spec.ts
Outdated
Show resolved
Hide resolved
src/elements/pearl-chain/pearl-chain/pearl-chain.sample-data.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
added
diff-available
and removed
preview-available
diff-available
labels
Oct 29, 2024
MarioCastigliano
requested review from
kyubisation and
jeripeierSBB
as code owners
October 30, 2024 10:07
jeripeierSBB
changed the title
refactor(pearl-chain): implement new component structure
feat(pearl-chain): implement new component structure
Nov 13, 2024
jeripeierSBB
changed the title
feat(pearl-chain): implement new component structure
feat(sbb-pearl-chain): implement new component structure
Nov 13, 2024
TomMenga
added
the
pr: lead review required
A lead review is required for this pull request
label
Nov 18, 2024
MarioCastigliano
force-pushed
the
refactor/pearl-chain
branch
from
December 2, 2024 13:23
1a7cc72
to
77f0d3c
Compare
MarioCastigliano
force-pushed
the
refactor/pearl-chain
branch
from
December 12, 2024 10:41
132f2d6
to
8fc582d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: lead review required
A lead review is required for this pull request
pr: peer review required
A peer review is required for this pull request
pr: visual review required
target: 2.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preflight Checklist
Issue
This PR Closes #2335
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information