Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test visual regression focus without waiting #2694

Merged
merged 7 commits into from
Jun 3, 2024
Merged

test: test visual regression focus without waiting #2694

merged 7 commits into from
Jun 3, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@jeripeierSBB jeripeierSBB requested a review from kyubisation as a code owner May 27, 2024 08:18
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label May 27, 2024
@github-actions github-actions bot temporarily deployed to pr2694 May 27, 2024 08:32 Inactive
@github-actions github-actions bot temporarily deployed to pr2694 May 27, 2024 09:29 Inactive
@github-actions github-actions bot requested a deployment to pr2694 May 27, 2024 10:13 In progress
@github-actions github-actions bot temporarily deployed to pr2694 May 27, 2024 10:16 Inactive
@github-actions github-actions bot temporarily deployed to pr2694 May 28, 2024 13:19 Inactive
@github-actions github-actions bot temporarily deployed to pr2694 May 28, 2024 13:26 Inactive
@github-actions github-actions bot temporarily deployed to pr2694 May 28, 2024 17:52 Inactive
kyubisation
kyubisation approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tools/web-test-runner/visual-regression-plugin-config.js Outdated Show resolved Hide resolved
@jeripeierSBB jeripeierSBB merged commit 89e03b1 into main Jun 3, 2024
3 checks passed
@jeripeierSBB jeripeierSBB deleted the visual-regression-focus-next-try branch June 3, 2024 14:32
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 3, 2024
@github-actions github-actions bot requested a deployment to main June 3, 2024 14:45 In progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

Assignees
No one assigned
Labels
diff-available pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeripeierSBB @kyubisation