Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sbb-timetable-row): enhance trip status and display logic #2680

Merged
merged 17 commits into from
Jun 26, 2024
Merged

feat(sbb-timetable-row): enhance trip status and display logic #2680

merged 17 commits into from
Jun 26, 2024

Conversation

WalkingOS
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label May 22, 2024
@WalkingOS WalkingOS changed the title Feat/sbb timetable row fixes feat(sbb-timetable-row): enhance trip status and display logic May 22, 2024
@jeripeierSBB
Copy link
Contributor

Please also check test and build run because they fail: https://github.com/sbb-design-systems/lyne-components/actions/runs/9187404639/job/25265088222?pr=2680

@jeripeierSBB jeripeierSBB added pr: lead review required A lead review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels May 22, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label May 22, 2024
@github-actions github-actions bot temporarily deployed to pr2680 May 22, 2024 15:25 Inactive
@WalkingOS WalkingOS force-pushed the feat/sbb-timetable-row-fixes branch from bfd55bc to d44b9ab Compare May 23, 2024 11:22
@WalkingOS WalkingOS force-pushed the feat/sbb-timetable-row-fixes branch from 4026634 to 16f9f95 Compare May 29, 2024 11:26
@github-actions github-actions bot temporarily deployed to pr2680 June 4, 2024 12:11 Inactive
@jeripeierSBB jeripeierSBB added the pr: blocked Pull request is blocked either for merging or reviewing label Jun 6, 2024
@jeripeierSBB
Merge branch 'refs/heads/main' into feat/sbb-timetable-row-fixes
e99e195 
# Conflicts:
#	src/elements-experimental/pearl-chain/pearl-chain.spec.ts
#	src/elements-experimental/timetable-row/timetable-row.spec.ts
@jeripeierSBB
fix: fix allCancelled logic according to Osman
864efe8
@jeripeierSBB
fix: fix test
4468678
@jeripeierSBB
fix: fix optional delay information
3a0456f
@jeripeierSBB jeripeierSBB removed the pr: blocked Pull request is blocked either for merging or reviewing label Jun 25, 2024
jeripeierSBB
jeripeierSBB approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added pr: lead review approved Pull request has been approved by a lead review and removed pr: lead review required A lead review is required for this pull request labels Jun 25, 2024
@jeripeierSBB jeripeierSBB merged commit 6e0424f into main Jun 26, 2024
29 of 30 checks passed
@jeripeierSBB jeripeierSBB deleted the feat/sbb-timetable-row-fixes branch June 26, 2024 06:56
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Jun 26, 2024
This was referenced Jun 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WalkingOS @jeripeierSBB