refactor: convert platform functions to constants #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with the SWC minifier seems to be caused by using isBrowser() in the static getter on SbbLanguageController. We replace this usage by isServer from lit, which is a constant. This should prevent the symbol from isBrowser() to be removed, as the compiler can already remove it during build time.
github-actions
bot
added
pr: peer review required
kyubisation
changed the title
github-actions
bot
removed
the
pr: peer review required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the platform functions to constants, as the value will not change and re-evaluation is not necessary.
Additionally we hope to mitigate issues with the SWC compiler.