Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use typed PropertyValues and always call super method of willChange #2642

Merged
merged 3 commits into from
May 7, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@jeripeierSBB jeripeierSBB requested a review from kyubisation as a code owner May 7, 2024 08:04
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label May 7, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks!
Looking at this, we should probably have a linting rule to cover these cases.

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label May 7, 2024
@kyubisation kyubisation merged commit 58978fb into main May 7, 2024
21 checks passed
@kyubisation kyubisation deleted the refactor-propertyvalues branch May 7, 2024 09:57
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants