Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbb-dialog): show all content if header is always present #2637

Merged
merged 1 commit into from
May 7, 2024

Conversation

jeripeierSBB
Copy link
Contributor

Closes #2635

needs review of @dauriamarco

@jeripeierSBB jeripeierSBB requested a review from dauriamarco May 6, 2024 13:55
@jeripeierSBB jeripeierSBB requested a review from kyubisation as a code owner May 6, 2024 13:55
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (e6397df) to head (f2fba7c).
Report is 60 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
+ Coverage   93.18%   93.23%   +0.04%     
==========================================
  Files         316      316              
  Lines       25389    25346      -43     
  Branches     2063     2070       +7     
==========================================
- Hits        23660    23631      -29     
+ Misses       1696     1682      -14     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label May 7, 2024
@kyubisation kyubisation merged commit 924fa37 into main May 7, 2024
23 checks passed
@kyubisation kyubisation deleted the fix-dialog-content-margin branch May 7, 2024 09:54
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: sbb-dialog content truncated at bottom in small viewports
3 participants