Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add section about focus outlines #2634

Merged
merged 3 commits into from
May 7, 2024
Merged

docs: add section about focus outlines #2634

merged 3 commits into from
May 7, 2024

Conversation

jeripeierSBB
Copy link
Contributor

No description provided.

@jeripeierSBB jeripeierSBB requested a review from kyubisation as a code owner May 6, 2024 08:17
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label May 6, 2024
@github-actions github-actions bot requested a deployment to preview-pr2634 May 6, 2024 08:27 In progress
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (e6397df) to head (6903565).
Report is 57 commits behind head on main.

❗ Current head 6903565 differs from pull request most recent head 700841f. Consider uploading reports for the commit 700841f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2634      +/-   ##
==========================================
+ Coverage   93.18%   93.23%   +0.04%     
==========================================
  Files         316      316              
  Lines       25389    25346      -43     
  Branches     2063     2066       +3     
==========================================
- Hits        23660    23631      -29     
+ Misses       1696     1682      -14     
  Partials       33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TomMenga
TomMenga requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo

docs/GETTING_STARTED.md Outdated Show resolved Hide resolved
@jeripeierSBB @TomMenga
fix: review
83cb6e9 
Co-authored-by: Tommmaso Menga <[email protected]>
@jeripeierSBB jeripeierSBB requested a review from TomMenga May 7, 2024 08:32
TomMenga
TomMenga requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, the suggestion was a choice between 2 options

docs/GETTING_STARTED.md Outdated Show resolved Hide resolved
@jeripeierSBB @TomMenga
fix: review
700841f 
Co-authored-by: Tommmaso Menga <[email protected]>
@jeripeierSBB
Copy link
Contributor Author

my bad, the suggestion was a choice between 2 options

Oops, I was too fast :D

@jeripeierSBB jeripeierSBB requested a review from TomMenga May 7, 2024 08:39
TomMenga
TomMenga approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels May 7, 2024
kyubisation
kyubisation approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label May 7, 2024
@kyubisation kyubisation merged commit ec653f1 into main May 7, 2024
25 checks passed
@kyubisation kyubisation deleted the focus-outline-docs branch May 7, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomMenga TomMenga TomMenga approved these changes

@kyubisation kyubisation kyubisation approved these changes

Assignees
No one assigned
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeripeierSBB @codecov-commenter @kyubisation @TomMenga