fix: avoid minifying identifiers to support SWC/next.js minifier #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: peer review required
TomMenga
approved these changes
Apr 30, 2024
github-actions
bot
added
pr: peer review approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2626 +/- ##
==========================================
+ Coverage 93.18% 93.23% +0.04%
==========================================
Files 316 316
Lines 25389 25346 -43
Branches 2063 2070 +7
==========================================
- Hits 23660 23631 -29
+ Misses 1696 1682 -14
Partials 33 33 ☔ View full report in Codecov by Sentry. |
jeripeierSBB
changed the title
kyubisation
added
the
pr: blocked
|
I have reservations about this. This is fine, if there are no possible workarounds, but we will challenge this first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.