-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reduce font-faces to single SBB variant #2618
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
==========================================
+ Coverage 93.18% 93.23% +0.04%
==========================================
Files 316 316
Lines 25389 25346 -43
Branches 2063 2070 +7
==========================================
- Hits 23660 23631 -29
+ Misses 1696 1682 -14
Partials 33 33 ☔ View full report in Codecov by Sentry. |
f372cc2
to
40d74b1
Compare
40d74b1
to
e8086c3
Compare
BREAKING CHANGE: replaced Roman, bold, and light font-face variants with the single "SbbWeb" font. Using font-weight chooses the correct font-family.
e8086c3
to
66a54e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Nice work! 😃
BEGIN_COMMIT_OVERRIDE
feat: reduce font-faces to the single SBB variant (#2618)
BREAKING CHANGE: Replaced
Roman
,Bold
, andLight
font-face variants with the singleSBB
font. Using CSSfont-weight
property automatically selects the correct font family. Migration guide:font-family: "SBBWeb Roman", ...
withfont-family: "SBB", ...
and usefont-weight: normal
(potentially not necessary asnormal
is the default).font-family: "SBBWeb Bold", ...
withfont-family: "SBB", ...
and usefont-weight: bold
or CSS classsbb-text--bold
.font-family: "SBBWeb Light", ...
withfont-family: "SBB", ...
and usefont-weight: 300
.--sbb-typo-type-face-sbb-roman
with--sbb-typo-font-family
and usefont-weight: normal
(potentially not necessary asnormal
is the default).--sbb-typo-type-face-sbb-bold
with--sbb-typo-font-family
and usefont-weight: bold
.--sbb-typo-type-face-sbb-light
with--sbb-typo-font-family
and usefont-weight: 300
.END_COMMIT_OVERRIDE
Closes #2614
BREAKING CHANGE: replaced Roman, Bold, and Light font-face variants with the single "SBB" font.
Using CSS
font-weight
property automatically selects the correct font family.Migration guide:
font-family: "SBBWeb Roman", ...
withfont-family: "SBB", ...
and usefont-weight: normal
(potentially not necessary asnormal
is the default).font-family: "SBBWeb Bold", ...
withfont-family: "SBB", ...
and usefont-weight: bold
or CSS classsbb-text--bold
.font-family: "SBBWeb Light", ...
withfont-family: "SBB", ...
and usefont-weight: 300
.--sbb-typo-type-face-sbb-roman
with--sbb-typo-font-family
and usefont-weight: normal
(potentially not necessary asnormal
is the default).--sbb-typo-type-face-sbb-bold
with--sbb-typo-font-family
and usefont-weight: bold
.--sbb-typo-type-face-sbb-light
with--sbb-typo-font-family
and usefont-weight: 300
.