Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce font-faces to single SBB variant #2618

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Apr 24, 2024

BEGIN_COMMIT_OVERRIDE
feat: reduce font-faces to the single SBB variant (#2618)

BREAKING CHANGE: Replaced Roman, Bold, and Light font-face variants with the single SBB font. Using CSS font-weight property automatically selects the correct font family. Migration guide:

  • Replace font-family: "SBBWeb Roman", ... with font-family: "SBB", ... and use font-weight: normal (potentially not necessary as normal is the default).
  • Replace font-family: "SBBWeb Bold", ... with font-family: "SBB", ... and use font-weight: bold or CSS class sbb-text--bold.
  • Replace font-family: "SBBWeb Light", ... with font-family: "SBB", ... and use font-weight: 300.
  • Replace CSS variable --sbb-typo-type-face-sbb-roman with --sbb-typo-font-family and use font-weight: normal (potentially not necessary as normal is the default).
  • Replace CSS variable --sbb-typo-type-face-sbb-bold with --sbb-typo-font-family and use font-weight: bold.
  • Replace CSS variable --sbb-typo-type-face-sbb-light with --sbb-typo-font-family and use font-weight: 300.

END_COMMIT_OVERRIDE

Closes #2614

BREAKING CHANGE: replaced Roman, Bold, and Light font-face variants with the single "SBB" font.
Using CSS font-weight property automatically selects the correct font family.
Migration guide:

  • Replace font-family: "SBBWeb Roman", ... with font-family: "SBB", ... and use font-weight: normal (potentially not necessary as normal is the default).
  • Replace font-family: "SBBWeb Bold", ... with font-family: "SBB", ... and use font-weight: bold or CSS class sbb-text--bold.
  • Replace font-family: "SBBWeb Light", ... with font-family: "SBB", ... and use font-weight: 300.
  • Replace CSS variable --sbb-typo-type-face-sbb-roman with --sbb-typo-font-family and use font-weight: normal (potentially not necessary as normal is the default).
  • Replace CSS variable --sbb-typo-type-face-sbb-bold with --sbb-typo-font-family and use font-weight: bold.
  • Replace CSS variable --sbb-typo-type-face-sbb-light with --sbb-typo-font-family and use font-weight: 300.

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Apr 24, 2024
@github-actions github-actions bot temporarily deployed to preview-pr2618 April 24, 2024 19:18 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (e6397df) to head (66a54e0).
Report is 23 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2618      +/-   ##
==========================================
+ Coverage   93.18%   93.23%   +0.04%     
==========================================
  Files         316      316              
  Lines       25389    25346      -43     
  Branches     2063     2070       +7     
==========================================
- Hits        23660    23631      -29     
+ Misses       1696     1682      -14     
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr2618 April 24, 2024 20:51 Inactive
@jeripeierSBB jeripeierSBB requested a review from mcilurzo April 25, 2024 06:39
@github-actions github-actions bot temporarily deployed to preview-pr2618 April 25, 2024 06:48 Inactive
BREAKING CHANGE: replaced Roman, bold, and light font-face variants with the single "SbbWeb" font.
 Using font-weight chooses the correct font-family.
@jeripeierSBB jeripeierSBB changed the title feat: reduce font-faces to single SbbWeb variant feat: reduce font-faces to single SBB variant Apr 25, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Nice work! 😃

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Apr 25, 2024
@jeripeierSBB jeripeierSBB merged commit 679d9e9 into main Apr 29, 2024
36 checks passed
@jeripeierSBB jeripeierSBB deleted the use-one-font branch April 29, 2024 05:32
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate merging font faces with font-weight
3 participants